search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
389 stars 91 forks source link

WIP: mbw unit test coverage #598

Closed h-w-chen closed 2 weeks ago

h-w-chen commented 1 month ago

What type of PR is this?

None - just want to check the coverage of added test

What this PR does / why we need it:

pre-PR of memory bandwidth management plugin; at this stage, to make sure the test cases of code that will be submitted provide adequate coverage

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 51.41956% with 462 lines in your changes missing coverage. Please review.

Project coverage is 56.64%. Comparing base (c9f1aaf) to head (7ed46a2). Report is 2 commits behind head on main.

:exclamation: Current head 7ed46a2 differs from pull request most recent head e2b3b62

Please upload reports for the commit e2b3b62 to get more accurate results.

Files Patch % Lines
pkg/mbw/monitor/monitor.go 43.38% 96 Missing and 11 partials :warning:
pkg/mbw/monitor/types.go 34.48% 54 Missing and 3 partials :warning:
pkg/mbw/monitor/umc.go 0.00% 55 Missing :warning:
pkg/mbw/monitor/l3pmc.go 42.85% 43 Missing and 1 partial :warning:
pkg/mbw/utils/helper.go 78.32% 23 Missing and 8 partials :warning:
pkg/mbw/utils/pci/pciutils.go 50.00% 29 Missing and 2 partials :warning:
pkg/mbw/monitor/rdt.go 28.20% 26 Missing and 2 partials :warning:
pkg/mbw/monitor/monitor_util.go 0.00% 26 Missing :warning:
pkg/mbw/monitor/pci.go 0.00% 16 Missing :warning:
pkg/mbw/utils/rdt/rdt.go 30.43% 11 Missing and 5 partials :warning:
... and 10 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #598 +/- ## ========================================== + Coverage 56.62% 56.64% +0.02% ========================================== Files 544 567 +23 Lines 51408 52492 +1084 ========================================== + Hits 29108 29735 +627 - Misses 18603 19023 +420 - Partials 3697 3734 +37 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/598/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/598/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.64% <51.41%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

h-w-chen commented 2 weeks ago

official PR had been pushed out for review. this pre-mr had served its purpose already.