search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
389 stars 91 forks source link

refactor(async): support limited async workers #605

Closed cheney-lin closed 4 weeks ago

cheney-lin commented 1 month ago

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 67.40331% with 59 lines in your changes missing coverage. Please review.

Project coverage is 56.04%. Comparing base (8c5f5f2) to head (0587f2b).

Files Patch % Lines
pkg/util/asyncworker/async_limited_workers.go 68.96% 36 Missing and 18 partials :warning:
...ins/memory/dynamicpolicy/policy_advisor_handler.go 0.00% 3 Missing :warning:
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 50.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #605 +/- ## ========================================== - Coverage 56.06% 56.04% -0.03% ========================================== Files 535 536 +1 Lines 49871 50051 +180 ========================================== + Hits 27961 28051 +90 - Misses 18341 18414 +73 - Partials 3569 3586 +17 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/605/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/605/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.04% <67.40%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.