search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
389 stars 91 forks source link

agent get SPD syncly & spd creation improvement #606

Open ddjjia opened 1 month ago

ddjjia commented 1 month ago

https://github.com/kubewharf/katalyst-core/pull/558/commits https://github.com/kubewharf/katalyst-core/pull/561/commits

What type of PR is this?

What this PR does / why we need it:

agent get SPD syncly & spd creation improvement

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 53.84615% with 72 lines in your changes missing coverage. Please review.

Project coverage is 57.02%. Comparing base (496cc71) to head (1b1a289). Report is 8 commits behind head on main.

Files Patch % Lines
pkg/controller/spd/spd.go 54.62% 42 Missing and 12 partials :warning:
pkg/metaserver/spd/fetcher.go 51.85% 9 Missing and 4 partials :warning:
pkg/controller/spd/indicator-plugin/plugin.go 0.00% 2 Missing :warning:
...ugin/plugins/resource-portrait/indicator_plugin.go 0.00% 2 Missing :warning:
...atalyst-agent/app/options/metaserver/metaserver.go 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #606 +/- ## ========================================== + Coverage 56.99% 57.02% +0.02% ========================================== Files 544 544 Lines 51682 51915 +233 ========================================== + Hits 29454 29602 +148 - Misses 18508 18572 +64 - Partials 3720 3741 +21 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/606/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/606/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `57.02% <53.84%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.