codecov[bot]
commented
3 weeks ago Codecov Report
Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.
Project coverage is 56.19%. Comparing base (
5e1814b) to head (02597ce). Report is 13 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| pkg/agent/orm/manager.go | 70.58% | 3 Missing and 2 partials :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #620 +/- ## ========================================== + Coverage 56.14% 56.19% +0.04% ========================================== Files 535 543 +8 Lines 49865 50387 +522 ========================================== + Hits 27997 28315 +318 - Misses 18307 18474 +167 - Partials 3561 3598 +37 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/620/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.19% <73.68%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What type of PR is this?
Bug fixes
What this PR does / why we need it:
Skip pods which are not system cores but owned by daemonSet when getTopologyHints in ORM.
Which issue(s) this PR fixes:
Special notes for your reviewer: