search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
389 stars 91 forks source link

chore(*): support dynamic config for cpu provision #623

Closed cheney-lin closed 3 weeks ago

cheney-lin commented 3 weeks ago

What type of PR is this?

Features

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 79.31873% with 85 lines in your changes missing coverage. Please review.

Project coverage is 56.86%. Comparing base (5060714) to head (f068c0f). Report is 1 commits behind head on main.

Files Patch % Lines
.../options/dynamic/adminqos/advisor/cpu_provision.go 51.61% 39 Missing and 6 partials :warning:
...pu/assembler/headroomassembler/assembler_common.go 83.92% 5 Missing and 4 partials :warning:
...lugin/qosaware/resource/cpu/region/region_share.go 43.75% 9 Missing :warning:
...u/assembler/provisionassembler/assembler_common.go 92.30% 4 Missing and 2 partials :warning:
...plugin/qosaware/resource/cpu/region/region_base.go 72.22% 2 Missing and 3 partials :warning:
...esource/cpu/assembler/provisionassembler/helper.go 92.00% 1 Missing and 1 partial :warning:
pkg/agent/sysadvisor/types/helper.go 85.71% 1 Missing and 1 partial :warning:
pkg/util/general/common.go 81.81% 2 Missing :warning:
pkg/util/general/deepcopy.go 71.42% 1 Missing and 1 partial :warning:
...p/options/dynamic/adminqos/advisor/advisor_base.go 75.00% 1 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #623 +/- ## ========================================== + Coverage 56.63% 56.86% +0.22% ========================================== Files 545 542 -3 Lines 51541 51640 +99 ========================================== + Hits 29192 29364 +172 + Misses 18649 18578 -71 + Partials 3700 3698 -2 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/623/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.86% <79.31%> (+0.22%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.