search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
389 stars 91 forks source link

feat: support shared_cores overlap reclaimed_cores #625

Closed cheney-lin closed 2 days ago

cheney-lin commented 3 weeks ago

What type of PR is this?

Features

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 82.26164% with 80 lines in your changes missing coverage. Please review.

Project coverage is 56.83%. Comparing base (d3a4e78) to head (9e97c26).

Files Patch % Lines
.../options/dynamic/adminqos/advisor/cpu_provision.go 52.52% 37 Missing and 10 partials :warning:
...pu/assembler/headroomassembler/assembler_common.go 83.92% 5 Missing and 4 partials :warning:
...u/assembler/provisionassembler/assembler_common.go 94.25% 3 Missing and 2 partials :warning:
...plugin/qosaware/resource/cpu/region/region_base.go 79.16% 2 Missing and 3 partials :warning:
...lugin/qosaware/resource/cpu/region/region_share.go 82.60% 2 Missing and 2 partials :warning:
...esource/cpu/assembler/provisionassembler/helper.go 92.00% 1 Missing and 1 partial :warning:
pkg/agent/sysadvisor/types/helper.go 85.71% 1 Missing and 1 partial :warning:
pkg/util/general/deepcopy.go 71.42% 1 Missing and 1 partial :warning:
...p/options/dynamic/adminqos/advisor/advisor_base.go 75.00% 1 Missing :warning:
...sysadvisor/plugin/qosaware/resource/cpu/advisor.go 90.90% 1 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #625 +/- ## ========================================== + Coverage 56.82% 56.83% +0.01% ========================================== Files 545 544 -1 Lines 51559 51682 +123 ========================================== + Hits 29300 29376 +76 - Misses 18549 18588 +39 - Partials 3710 3718 +8 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/625/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/625/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.83% <82.26%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.