search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
389 stars 91 forks source link

feat(qrm): move_pages use async limited workers #627

Closed yadzhang closed 1 week ago

yadzhang commented 2 weeks ago

What type of PR is this?

Enhancements

What this PR does / why we need it:

use aysnc limited workers to limit concurrency for move_pages action, to reduce numa memory bandwidth occupancy and latencey

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 46.15385% with 14 lines in your changes missing coverage. Please review.

Project coverage is 56.72%. Comparing base (4858a44) to head (373d864).

Files Patch % Lines
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 37.50% 5 Missing :warning:
...m-plugins/memory/dynamicpolicy/util_linux_amd64.go 0.00% 5 Missing :warning:
...memory/dynamicpolicy/policy_allocation_handlers.go 75.00% 2 Missing and 1 partial :warning:
...ins/memory/dynamicpolicy/policy_advisor_handler.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #627 +/- ## ========================================== - Coverage 56.75% 56.72% -0.03% ========================================== Files 545 545 Lines 51537 51555 +18 ========================================== - Hits 29248 29246 -2 - Misses 18583 18616 +33 + Partials 3706 3693 -13 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/627/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/627/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.72% <46.15%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.