search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
389 stars 91 forks source link

feat(sysadvisor): optimize run servers #632

Closed nightmeng closed 1 week ago

nightmeng commented 2 weeks ago

What type of PR is this?

Enhancements

What this PR does / why we need it:

Optimize the advisor run servers logic

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 56.60%. Comparing base (3d88b72) to head (3ed017f). Report is 4 commits behind head on main.

Files Patch % Lines
...t/sysadvisor/plugin/qosaware/server/base_server.go 52.38% 6 Missing and 4 partials :warning:
...sysadvisor/plugin/qosaware/resource/cpu/advisor.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #632 +/- ## ========================================== - Coverage 56.82% 56.60% -0.23% ========================================== Files 545 545 Lines 51561 51555 -6 ========================================== - Hits 29300 29182 -118 - Misses 18551 18680 +129 + Partials 3710 3693 -17 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/632/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.60% <63.33%> (-0.23%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.