search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
389 stars 91 forks source link

feat: add npd controller #633

Open WangZzzhe opened 1 week ago

WangZzzhe commented 1 week ago

What type of PR is this?

Features

What this PR does / why we need it:

add NPD controller api should be replaced after https://github.com/kubewharf/katalyst-api/pull/84 merged

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 64.89676% with 119 lines in your changes missing coverage. Please review.

Project coverage is 56.77%. Comparing base (4858a44) to head (810e743). Report is 11 commits behind head on main.

Files Patch % Lines
pkg/controller/npd/npd.go 66.16% 35 Missing and 10 partials :warning:
pkg/controller/npd/npd_indicator.go 59.25% 16 Missing and 6 partials :warning:
pkg/controller/npd/handler.go 31.03% 15 Missing and 5 partials :warning:
cmd/katalyst-controller/app/options/npd.go 43.47% 13 Missing :warning:
pkg/client/control/npd.go 47.36% 8 Missing and 2 partials :warning:
pkg/util/npd.go 80.00% 2 Missing and 2 partials :warning:
pkg/controller/npd/indicator-plugin/manager.go 93.02% 2 Missing and 1 partial :warning:
cmd/katalyst-controller/app/options/controller.go 66.66% 1 Missing :warning:
pkg/controller/npd/indicator-plugin/plugin.go 93.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #633 +/- ## ========================================== + Coverage 56.75% 56.77% +0.02% ========================================== Files 545 553 +8 Lines 51537 51876 +339 ========================================== + Hits 29248 29451 +203 - Misses 18583 18704 +121 - Partials 3706 3721 +15 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/633/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.77% <64.89%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.