search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
389 stars 91 forks source link

WIP: pre-mr (mbm control) #639

Closed h-w-chen closed 6 days ago

h-w-chen commented 6 days ago

What type of PR is this?

NA - pre-MR to see how the test coverage number would be

What this PR does / why we need it:

pre-MR to see how the test coverage number would be

Which issue(s) this PR fixes:

Special notes for your reviewer:

please ignore this for now; this is WIP

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 52.52525% with 564 lines in your changes missing coverage. Please review.

Project coverage is 56.75%. Comparing base (c9f1aaf) to head (b757543). Report is 15 commits behind head on main.

Files Patch % Lines
pkg/mbw/monitor/monitor.go 39.54% 96 Missing and 11 partials :warning:
pkg/mbw/monitor/controller.go 21.97% 68 Missing and 3 partials :warning:
pkg/mbw/monitor/umc.go 0.00% 55 Missing :warning:
...agent/qrm-plugins/cpu/dynamicpolicy/mbm/control.go 61.85% 29 Missing and 8 partials :warning:
pkg/mbw/monitor/l3pmc.go 59.74% 28 Missing and 3 partials :warning:
pkg/mbw/utils/pci/pciutils.go 50.00% 29 Missing and 2 partials :warning:
pkg/mbw/utils/helper.go 79.72% 21 Missing and 8 partials :warning:
pkg/mbw/monitor/rdt.go 28.20% 26 Missing and 2 partials :warning:
pkg/mbw/monitor/monitor_util.go 0.00% 26 Missing :warning:
pkg/util/machine/extension.go 55.55% 21 Missing and 3 partials :warning:
... and 18 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #639 +/- ## ========================================== + Coverage 56.62% 56.75% +0.12% ========================================== Files 544 570 +26 Lines 51408 52746 +1338 ========================================== + Hits 29108 29934 +826 - Misses 18603 19049 +446 - Partials 3697 3763 +66 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.75% <52.52%> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

h-w-chen commented 6 days ago

squashed to a new one w/ fewer commits