search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
394 stars 91 forks source link

fix(advisor): fix reclaim overlap share cores #644

Closed cheney-lin closed 1 week ago

cheney-lin commented 1 week ago

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.85%. Comparing base (8fd9290) to head (46ed456).

Files Patch % Lines
...esource/cpu/assembler/provisionassembler/helper.go 90.47% 1 Missing and 1 partial :warning:
...u/assembler/provisionassembler/assembler_common.go 91.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #644 +/- ## ========================================== - Coverage 56.90% 56.85% -0.06% ========================================== Files 544 544 Lines 51808 51826 +18 ========================================== - Hits 29482 29465 -17 - Misses 18606 18635 +29 - Partials 3720 3726 +6 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/644/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/644/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.85% <90.90%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.