search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
394 stars 91 forks source link

fix(advisor): optimize lw health check #645

Closed nightmeng closed 13 hours ago

nightmeng commented 1 week ago

What type of PR is this?

Enhancements

What this PR does / why we need it:

Support short time health check

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 58.58586% with 41 lines in your changes missing coverage. Please review.

Project coverage is 56.86%. Comparing base (8e82f8c) to head (0b75b6d). Report is 3 commits behind head on main.

Files Patch % Lines
pkg/util/general/healthz.go 57.53% 25 Missing and 6 partials :warning:
...nt/sysadvisor/plugin/qosaware/server/cpu_server.go 72.72% 3 Missing :warning:
...sysadvisor/plugin/qosaware/server/memory_server.go 72.72% 3 Missing :warning:
...sysadvisor/plugin/qosaware/resource/cpu/advisor.go 0.00% 2 Missing :warning:
...advisor/plugin/qosaware/resource/memory/advisor.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #645 +/- ## ======================================= Coverage 56.86% 56.86% ======================================= Files 552 552 Lines 52735 52830 +95 ======================================= + Hits 29988 30044 +56 - Misses 18982 19015 +33 - Partials 3765 3771 +6 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.86% <58.58%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.