kubewharf / kelemetry

Global control plane tracing for Kubernetes
Apache License 2.0
252 stars 28 forks source link

refactor: unify the ObjectRef and GroupingKey types #158

Closed SOF3 closed 1 year ago

SOF3 commented 1 year ago

Description

Related issues

Special notes for your reviewer:

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 6.45% and project coverage change: -0.81% :warning:

Comparison is base (f511c44) 37.63% compared to head (880213c) 36.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #158 +/- ## ========================================== - Coverage 37.63% 36.82% -0.81% ========================================== Files 32 33 +1 Lines 2559 2626 +67 ========================================== + Hits 963 967 +4 - Misses 1533 1596 +63 Partials 63 63 ``` | [Files Changed](https://app.codecov.io/gh/kubewharf/kelemetry/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [pkg/diff/cache/interface.go](https://app.codecov.io/gh/kubewharf/kelemetry/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#diff-cGtnL2RpZmYvY2FjaGUvaW50ZXJmYWNlLmdv) | `11.26% <0.00%> (ø)` | | | [pkg/diff/cache/memory\_wrapper.go](https://app.codecov.io/gh/kubewharf/kelemetry/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#diff-cGtnL2RpZmYvY2FjaGUvbWVtb3J5X3dyYXBwZXIuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/util/object/rich.go](https://app.codecov.io/gh/kubewharf/kelemetry/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#diff-cGtnL3V0aWwvb2JqZWN0L3JpY2guZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/util/object/key.go](https://app.codecov.io/gh/kubewharf/kelemetry/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#diff-cGtnL3V0aWwvb2JqZWN0L2tleS5nbw==) | `5.00% <5.00%> (ø)` | | | [pkg/k8s/objectcache/objectcache.go](https://app.codecov.io/gh/kubewharf/kelemetry/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#diff-cGtnL2s4cy9vYmplY3RjYWNoZS9vYmplY3RjYWNoZS5nbw==) | `51.35% <80.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.