search

kubewharf / kelemetry

Global control plane tracing for Kubernetes
Apache License 2.0
252 stars 28 forks source link

fix: macos quickstart err #330

Open ls-2018 opened 4 months ago

ls-2018 commented 4 months ago

You should not use the gateway address, but the address where the application uses control-plane

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

SOF3 commented 4 months ago

Actually iirc host.docker.internal should just work out of the box in macos

ls-2018 commented 4 months ago

@SOF3 However, on my computer, host.docker.internal and gateway are not the same IP, of course, I believe there are other people who are the same as me. I think the IP using xx-control-plane is more accurate

SOF3 commented 3 months ago

It doesn't look like the change works on Linux, as seen from the failing CI.