search

kubewharf / kelemetry

Global control plane tracing for Kubernetes
Apache License 2.0
245 stars 29 forks source link

fix(diff): diff controller would deadlock when leader re-elects #334

Closed SOF3 closed 2 months ago

SOF3 commented 2 months ago

Description

When diff controller exits, there is a mutex reentrance deadlock bug that prevents the next leader session from acquiring the lock to continue watching.

image

Related issues

Special notes for your reviewer:

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 17.72%. Comparing base (38cb0af) to head (740643e).

Files Patch % Lines
pkg/util/channel/channel.go 0.00% 10 Missing :warning:
pkg/k8s/multileader/elector.go 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #334 +/- ## ========================================== - Coverage 17.74% 17.72% -0.03% ========================================== Files 103 103 Lines 9444 9458 +14 ========================================== Hits 1676 1676 - Misses 7672 7686 +14 Partials 96 96 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.