search

kubewharf / kubeadmiral

Multi-Cluster Kubernetes Orchestration
Apache License 2.0
658 stars 89 forks source link

refactor: remove redundant returned error #290

Open z1cheng opened 7 months ago

z1cheng commented 7 months ago

close #99

codecov[bot] commented 7 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (eba0d26) 33.28% compared to head (53df1bc) 31.49%.

:exclamation: Current head 53df1bc differs from pull request most recent head 612b1aa. Consider uploading reports for the commit 612b1aa to get more accurate results

Files Patch % Lines
...controllers/statusaggregator/plugins/deployment.go 0.00% 2 Missing :warning:
pkg/util/annotation/annotation.go 88.23% 2 Missing :warning:
pkg/controllers/nsautoprop/controller.go 0.00% 1 Missing :warning:
pkg/controllers/status/controller.go 0.00% 1 Missing :warning:
pkg/controllers/sync/resource.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #290 +/- ## ========================================== - Coverage 33.28% 31.49% -1.79% ========================================== Files 155 122 -33 Lines 17892 14300 -3592 ========================================== - Hits 5955 4504 -1451 + Misses 11427 9391 -2036 + Partials 510 405 -105 ``` | [Flag](https://app.codecov.io/gh/kubewharf/kubeadmiral/pull/290/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/kubewharf/kubeadmiral/pull/290/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `31.49% <76.66%> (-1.79%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.