search

kubewharf / kubeadmiral

Multi-Cluster Kubernetes Orchestration
Apache License 2.0
658 stars 89 forks source link

chore: fix receiver naming #308

Closed Larry-shuo closed 6 months ago

Larry-shuo commented 6 months ago

replace pp with cpp as the receiver name of ClusterPropagationPolicy:

  1. keep the consistency with other place;
  2. avoid the confusion with pp of PropagationPolicy.
CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1a2c9ff) 33.84% compared to head (b68d09c) 33.84%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #308 +/- ## ======================================= Coverage 33.84% 33.84% ======================================= Files 149 149 Lines 16682 16682 ======================================= Hits 5646 5646 Misses 10559 10559 Partials 477 477 ``` | [Flag](https://app.codecov.io/gh/kubewharf/kubeadmiral/pull/308/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/kubewharf/kubeadmiral/pull/308/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `33.84% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.