codecov[bot]
commented
8 months ago Codecov Report
Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.
Project coverage is 33.20%. Comparing base (
eba0d26) to head (bc557fe).
| Files | Patch % | Lines |
|---|---|---|
| pkg/controllers/mcs/service_import_controller.go | 0.00% | 22 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #316 +/- ## ========================================== - Coverage 33.28% 33.20% -0.08% ========================================== Files 155 155 Lines 17892 17914 +22 ========================================== - Hits 5955 5948 -7 - Misses 11427 11457 +30 + Partials 510 509 -1 ``` | [Flag](https://app.codecov.io/gh/kubewharf/kubeadmiral/pull/316/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/kubewharf/kubeadmiral/pull/316/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `33.20% <0.00%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
When repeatedly creating and deleting mcs, and when processing the creation event of mcs, the federatedObject of the originally derived service may still be in the deletion state. Even if the update is successful, the derived service will still be deleted and there will be no chance to retry.