kubewharf / kubeadmiral

Multi-Cluster Kubernetes Orchestration
Apache License 2.0
658 stars 89 forks source link

fix(override): support overwriting finalizers via OverridePolicy #328

Closed JackZxj closed 1 month ago

JackZxj commented 1 month ago

Now you can use OP to overwrite finalizers like this:

spec:
  overrideRules:
  - overriders:
      jsonpatch:
      - operator: add
        path: /metadata/finalizers/0
        value: aaa.bbb.ccc/test
      - operator: replace
        path: /metadata/finalizers/0
        value: aaa.bbb.ccc/new-test
      # you'd better replace it all instead of removing by index, 
      # because the syncer might remove multiple times by index.
      # - operator: replace 
      #   path: /metadata/finalizers   
      #   value: []
    targetClusters:
      clusters:
      - kubeadmiral-member-2

NOTE: if you have added new finalizers to member cluster's resources, you have to remove all finalizers before you can delete the resource from the member cluster.