kubewharf / kubeadmiral

Multi-Cluster Kubernetes Orchestration
https://kubeadmiral.io
Apache License 2.0
802 stars 95 forks source link

fix(policyrc): clusterOverridePolicyInformer add wrong eventHandler #332

Closed zk-123 closed 3 months ago

zk-123 commented 3 months ago

fix(policyrc): clusterOverridePolicyInformer use persistOpWorker for eventHandler

zk-123 commented 3 months ago

@SOF3

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.43%. Comparing base (1f0e7ff) to head (daa6cc2). Report is 1 commits behind head on main.

Files Patch % Lines
pkg/controllers/policyrc/controller.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #332 +/- ## ========================================== - Coverage 33.46% 33.43% -0.04% ========================================== Files 155 155 Lines 14627 14627 ========================================== - Hits 4895 4890 -5 - Misses 9222 9228 +6 + Partials 510 509 -1 ``` | [Flag](https://app.codecov.io/gh/kubewharf/kubeadmiral/pull/332/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/kubewharf/kubeadmiral/pull/332/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `33.43% <0.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zk-123 commented 3 months ago

how to merge this branch into master when the coverage test has not passed?