search

kubewharf / kubebrain

A High Performance Metadata System for Kubernetes
Apache License 2.0
771 stars 77 forks source link

fix(endpoint): avoid calling cmux.Match concurrently #18

Closed divanodestiny closed 2 years ago

divanodestiny commented 2 years ago

Change-Id: I96d0742b4c2d31dec3fb2c82dbc29ebb5422743d

What type of PR is this?

Bug Fix

What this PR does / why we need it:

cmux.Match is not concurrent-safe. Register matcher in sequence to avoid risk of losing matcher.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@5e9ff77). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #18 +/- ## ======================================= Coverage ? 56.54% ======================================= Files ? 58 Lines ? 4678 Branches ? 0 ======================================= Hits ? 2645 Misses ? 1890 Partials ? 143 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

divanodestiny commented 2 years ago

PTAL @xuchen-xiaoying