search

kubewharf / kubebrain

A High Performance Metadata System for Kubernetes
Apache License 2.0
764 stars 79 forks source link

fix etcd watch cancel update metrics crash #25

Closed sky-big closed 1 year ago

sky-big commented 1 year ago

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Fix kubebrain crash when etcd watch cancel update metrics.

Detail: The watch.cancel indicator has a label. When two label values ​​are received, the prometheus library will crash.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@7b7aae4). Click here to learn what that means. Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #25 +/- ## ======================================= Coverage ? 58.43% ======================================= Files ? 60 Lines ? 4816 Branches ? 0 ======================================= Hits ? 2814 Misses ? 1854 Partials ? 148 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

divanodestiny commented 1 year ago

LGTM