search

kubewharf / kubebrain

A High Performance Metadata System for Kubernetes
Apache License 2.0
764 stars 79 forks source link

Fix the bug that etcd txn proxy fails to print response revision crash #28

Closed sky-big closed 1 year ago

sky-big commented 1 year ago

What type of PR is this? Bug fixes

What this PR does / why we need it: Fix kubebrain crash when etcd txn proxy fails to print response kv revision.

Detail: when the leader etcd txn create(or other action) fails, follower node print the revision of kv after receiving the error message from the leader, but the kv field is empty, so kubebrain process crash.

Which issue(s) this PR fixes: None

Special notes for your reviewer: None

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@95c10d5). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #28 +/- ## ======================================= Coverage ? 58.26% ======================================= Files ? 60 Lines ? 4821 Branches ? 0 ======================================= Hits ? 2809 Misses ? 1863 Partials ? 149 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

divanodestiny commented 1 year ago

@sky-big could you sign the commit and push again ? thx~

sky-big commented 1 year ago

@sky-big could you sign the commit and push again ? thx~

done.

divanodestiny commented 1 year ago

@sky-big could you sign the commit and push again ? thx~

done. Thx for your work.

There may be something wrong, which block the merging. I think you can follow this doc to enable github to verify your sign.

And you push to commit with the same commit msg. Could you squash in local?

sky-big commented 1 year ago

@divanodestiny I have squashed this commit, see if you can merge this request, how to verify your sign?

divanodestiny commented 1 year ago

@divanodestiny I have squashed this commit, see if you can merge this request, how to verify your sign?

@sky-big sorry, i forget to write the url. it is about-commit-signature-verification.

I can not merge this PR without breaking the branch protections. I think it would be better if you can follow the guideline , config the public key on Github and enable Github to verify your sign for the commit.

However, if you don’t want to do that, let me know that. Then i will try to force merge your PR.

Thx for your work again ~

sky-big commented 1 year ago

@divanodestiny I have squashed this commit, see if you can merge this request, how to verify your sign?

@sky-big sorry, i forget to write the url. it is about-commit-signature-verification.

I can not merge this PR without breaking the branch protections. I think it would be better if you can follow the guideline , config the public key on Github and enable Github to verify your sign for the commit.

However, if you don’t want to do that, let me know that. Then i will try to force merge your PR.

Thx for your work again ~

Done.