Several fixes and enhancements

kubic-project / kubic-terraform-kvm

Kubic Terraform script using KVM/libvirt

Apache License 2.0

31 stars 10 forks source link

Several fixes and enhancements #1

Closed vadorovsky closed 5 years ago

vadorovsky commented 5 years ago

This series provide the following changes:

a fix for download-image script to exit on error
a fix to mk-ssh-config to set 0600 permissions on the private key file (git does not store information about full permissions, only about the executable bit)
ability to configure VM parameters with variables

sebastian-philipp commented 5 years ago

Thanks! As you're changing the default number of CPUs to 2, can we now remove --ignore-preflight-errors=NumCPU from the README?

vadorovsky commented 5 years ago

@sebastian-philipp Yes. Sorry, I totally forgot about mentioning the change of vCPUs to 2 and I wasn't even sure whether I should commit it. ;) But from my experience, when you use just 1 vCPU, the Kubernetes cluster is barely usable and I had hard time with setting up Cilium on it. 2 vCPUs seem to be way better.

If you have no objections to the change of vCPU count, I'm going to change the README. :)

vadorovsky commented 5 years ago

Done.

sebastian-philipp commented 5 years ago

You're using it for Cilium? that's totally awesome