kubitron / redmine_git_hosting

A ChiliProject/Redmine plugin which makes configuring your own git hosting easy.
78 stars 15 forks source link

Repositories that arent the main one only get one of their two keys put in the gitolite-admin repo #109

Open GuillaumeFromage opened 11 years ago

GuillaumeFromage commented 11 years ago

The main repo is getting two keys, just like described in https://github.com/kubitron/redmine_git_hosting/issues/108 . However, repos that are "secondary", see only one key added. This is problematic for the users as the authorized_key is read in order, and if the key that isn't allowed login ends up first in that file, the user is denied access to all "secondary" repos.

I will post a workaround soonish (that will be so dirty that dirt itself will fell insulted by it).

GuillaumeFromage commented 11 years ago

I fixed this in the most horrible way possible.

I've patched the post-update gitolite-admin hook, by adding:

# THIS IS EVIL !
# THIS IS EVIL !
# We're waiting for a patch for https://github.com/kubitron/redmine_git_hosting/issues/109 and https://github.com/kubitron/redmine_git_hosting/issues/108

cd ; cat .ssh/authorized_keys | sed '/a-user-key-name/d' | sed '/another-user-key-name-/d' > .ssh/authorized_keys99 ; mv .ssh/authorized_keys99 .ssh/authorized_keys

At the end of the file. Dirty as fuck, but seriously, I don't wanna start digging around 350 files of this unmaintained plugin.

kubitron commented 11 years ago

Are you executing a "fetch_changesets" operation regularly as specified by the instructions? Seems like your keys got out of sync and this would fix that...

GuillaumeFromage commented 11 years ago

I did run rake gitolite:fetch_changes and redmine_git_hosting:fetch_changesets without success. Would you have time to give me pointers about where those are generated in the code ?