kubitron / redmine_git_hosting

A ChiliProject/Redmine plugin which makes configuring your own git hosting easy.
78 stars 15 forks source link

redmine git hosting on redmine 2.0 #52

Open gituser opened 12 years ago

gituser commented 12 years ago

$ rake db:migrate_plugins RAILS_ENV=production --trace * Invoke db:migrate_plugins (first_time) * Invoke redmine:plugins:migrate (first_time) * Invoke environment (first_time) * Execute environment rake aborted! no such file to load -- dispatcher /var/lib/gems/1.8/gems/activesupport-3.2.3/lib/active_support/dependencies.rb:251:in require' /var/lib/gems/1.8/gems/activesupport-3.2.3/lib/active_support/dependencies.rb:251:inrequire' /var/lib/gems/1.8/gems/activesupport-3.2.3/lib/active_support/dependencies.rb:236:in load_dependency' /var/lib/gems/1.8/gems/activesupport-3.2.3/lib/active_support/dependencies.rb:251:inrequire' /var/www/redmine/plugins/redmine_git_hosting/init.rb:50 /var/lib/gems/1.8/gems/activesupport-3.2.3/lib/active_support/dependencies.rb:251:in require' /var/lib/gems/1.8/gems/activesupport-3.2.3/lib/active_support/dependencies.rb:251:inrequire' /var/lib/gems/1.8/gems/activesupport-3.2.3/lib/active_support/dependencies.rb:236:in load_dependency' /var/lib/gems/1.8/gems/activesupport-3.2.3/lib/active_support/dependencies.rb:251:inrequire' /var/www/redmine/lib/redmine/plugin.rb:129:in load' /var/www/redmine/lib/redmine/plugin.rb:120:ineach' /var/www/redmine/lib/redmine/plugin.rb:120:in load' /var/www/redmine/config/initializers/30-redmine.rb:13 /var/lib/gems/1.8/gems/activesupport-3.2.3/lib/active_support/dependencies.rb:245:inload' /var/lib/gems/1.8/gems/activesupport-3.2.3/lib/active_support/dependencies.rb:245:in load' /var/lib/gems/1.8/gems/activesupport-3.2.3/lib/active_support/dependencies.rb:236:inload_dependency' /var/lib/gems/1.8/gems/activesupport-3.2.3/lib/active_support/dependencies.rb:245:in load' /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/engine.rb:588 /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/engine.rb:587:ineach' /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/engine.rb:587 /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/initializable.rb:30:in instance_exec' /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/initializable.rb:30:inrun' /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/initializable.rb:55:in run_initializers' /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/initializable.rb:54:ineach' /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/initializable.rb:54:in run_initializers' /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/application.rb:136:ininitialize!' /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/railtie/configurable.rb:30:in send' /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/railtie/configurable.rb:30:inmethod_missing' /var/www/redmine/config/environment.rb:14 /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/application.rb:103:in require' /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/application.rb:103:inrequire_environment!' /var/lib/gems/1.8/gems/railties-3.2.3/lib/rails/application.rb:292:in initialize_tasks' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:205:incall' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:205:in execute' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:200:ineach' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:200:in execute' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:158:ininvoke_with_call_chain' /usr/lib/ruby/1.8/monitor.rb:242:in synchronize' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:151:ininvoke_with_call_chain' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:176:in invoke_prerequisites' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:174:ineach' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:174:in invoke_prerequisites' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:157:ininvoke_with_call_chain' /usr/lib/ruby/1.8/monitor.rb:242:in synchronize' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:151:ininvoke_with_call_chain' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:176:in invoke_prerequisites' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:174:ineach' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:174:in invoke_prerequisites' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:157:ininvoke_with_call_chain' /usr/lib/ruby/1.8/monitor.rb:242:in synchronize' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:151:ininvoke_with_call_chain' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/task.rb:144:in invoke' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/application.rb:116:ininvoke_task' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/application.rb:94:in top_level' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/application.rb:94:ineach' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/application.rb:94:in top_level' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/application.rb:133:instandard_exception_handling' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/application.rb:88:in top_level' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/application.rb:66:inrun' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/application.rb:133:in standard_exception_handling' /var/lib/gems/1.8/gems/rake-0.9.2.2/lib/rake/application.rb:63:inrun' /var/lib/gems/1.8/gems/rake-0.9.2.2/bin/rake:33 /usr/bin/rake:19:in `load' /usr/bin/rake:19 Tasks: TOP => db:migrate_plugins => redmine:plugins:migrate => environment

in new redmine plugins dir was moved from ~/vendors/plugins to ~/plugins

is there a quickfix for this?

Thanks

kubitron commented 12 years ago

Sigh. Well, as the Readme says, this plugin is only for versions <= 1.3. I need to do some work to make this work in later releases (including 1.4). Thus, I have not even looked at Redmine 2.0.

Sounds like 2.0 is a bit more drastically rearranged. My guess that there is something far worse than what you are hung up on. Looks like I have to redesign the Rakefiles.

Hopefully I'll have time soon.

gituser commented 12 years ago

Ye, I went back to older version of redmine and it seems its also not working for some reason. (Project directory is not created) - investigating right now..

_*> uninitialized constant GitHosting::GitoliteConfig::ADMIN_REPO > /var/lib/gems/1.8/gems/activesupport-2.3.14/lib/active_support/dependencies.rb:131:in `const_missing' *> /var/www/redmine/vendor/plugins/redmine_git_hosting/lib/git_hosting.rb:418:in clone_or_pull_gitolite_admin' *__> /var/www/redmine/vendor/plugins/redmine_git_hosting/lib/git_hosting.rb:691:inupdate_repositories' __> /var/www/redmine/vendor/plugins/redmine_git_hosting/app/models/git_hosting_observer.rb:31:in `set_update_active' __> /var/www/redmine/vendor/plugins/redmine_git_hosting/app/models/git_hosting_observer.rb:48:in `bracketed_updaterepositories' **> git_hosting: update_repositories() failed

gituser commented 12 years ago

I think there is a problem with new gitolite3 as well...

:(

I have the same error as I had before it doesn't add keys to the authorized_keys.

Will try with gitolite2.

kubitron commented 12 years ago

This can be a gitolite installation problem... Try manually adding keys by altering the config file manually and pushing it... Perhaps your permissions are wrong.

gituser commented 12 years ago

ok, i found the issue was I forgot to add users to the project :( (on redmine 1.3.x)

you probably need to add this to how-to as well, didnt try with gitolite3, on g2, but with few modifications it should work on g3 i think too.

Will wait for redmine 2.0.x support, dont close this issue please before support added.

kubitron commented 12 years ago

Um... This plugin won't add keys if there are no keys to add.

However, it should create the repository even without users. Is it not doing that?

gituser commented 12 years ago

Hi.

Yes it creates empty repository.

It doesn't add keys if there are no users added to the project.

I just thought it should be noted because someone could be in stuck due this.

lutinwood commented 12 years ago

Hi, I'm using this plugin with the redmine's version 1.3 and gitolite 2 , I'm happy for the moment. I would like to prepare a migration to a newer version of redmine (2 or 1.4) . Do you think than we can imagine this plugin working with the latest redmine version (2 for instance) with (gitolite 3) or should I focus more on another couple (redmine 1.4, Gitolite 2).

Thanks... Jerry

gituser commented 12 years ago

it works just fine with 1.4 (i'm on it right now) but not with 2.0 as of yet.

kubitron commented 12 years ago

It doesn't really. If you look, the settings are missing. Also (more importantly), 1.4 allows more than one repo per project, and that really doesn't work. Also, I think that there are other random incompatibilities.

1.4 is next on my list, after I catch fix some other bugs. Next, 2.0 will get it.

If you want to try gitolite 3, I'd be curious whether that worked or not.

gituser commented 12 years ago

It doesn't really. If you look, the settings are missing. Also (more importantly), 1.4 allows more than one repo per >project, and that really doesn't work. Also, I think that there are other random incompatibilities.

yeah, true, but for the first time it worked for me (without specific settings), now it gives me some weird plain-text page if i click on settings (i made repository default for this project).

If you want to try gitolite 3, I'd be curious whether that worked or not. gitolite3 i tried but it didn't work for me because I didn't add relevant users to the repository.

gitolite2 works fine for me, g3's difference is there is 1 binary instead of multiple, so you'd need to change commands inside redmine_git_hosting as well.

kubitron commented 12 years ago

Ok. Sorry to all about the delay on this issue. I got really busy for the last couple of months...

gituser commented 12 years ago

no worries, currently redmine_git_hosting works for me apart from settings / my account

  Parameters: {"action"=>"account", "controller"=>"my"}
Rendering template within layouts/base
Rendering my/account

ActionView::TemplateError (undefined method `errors' for :gitolite_public_key:Symbol) on line #7 of vendor/plugins/redmine_git_hosting/app/views/my/account.html.erb:
4: </div>
5: <h2><%=l(:label_my_account)%></h2>
6: <%= error_messages_for 'user' %>
7: <%= error_messages_for :gitolite_public_key %>
8: 
9: <div class="splitcontentleft">
10:     <% labelled_form_for :user, @user, :url => { :action => "account" }, :html => { :id => 'my_account_form' } do |f| %>

    app/helpers/application_helper.rb:954:in `error_messages_for'
    app/helpers/application_helper.rb:954:in `map'
    app/helpers/application_helper.rb:954:in `error_messages_for'
    vendor/plugins/redmine_git_hosting/app/views/my/account.html.erb:7
    unicorn (4.3.1) lib/unicorn/http_server.rb:531:in `process_client'
    unicorn (4.3.1) lib/unicorn/http_server.rb:606:in `worker_loop'
    unicorn (4.3.1) lib/unicorn/http_server.rb:487:in `spawn_missing_workers'
    unicorn (4.3.1) lib/unicorn/http_server.rb:137:in `start'
    unicorn (4.3.1) bin/unicorn_rails:209
    /var/lib/gems/1.8/bin/unicorn_rails:19:in `load'
    /var/lib/gems/1.8/bin/unicorn_rails:19

happens if i go to my account

EDIT: fixed it just changed

 <%= error_messages_for :gitolite_public_key %>

to

 <%= error_messages_for 'gitolite_public_key' %>

and it worked

gituser commented 12 years ago

another bug found: if i click on my account, then click on edit button on specific key and instead of cancel'ing or saving it i hit save button on the left it gives me a blank page.

ghost commented 12 years ago

Any news-planning for this issue?

kubitron commented 12 years ago

Getting closer. Cleaning up some random other issues.

kubitron commented 12 years ago

@gituser The second bug you found is actually a current bug, not just a Redmine. Registering separate issue.

ghost commented 12 years ago

Thanks for your efforts much appreciated.

gituser commented 12 years ago

much appreciated, will test it more with g3 and report back.

kubitron commented 12 years ago

@gituser Ok. testing branch should fix both the dispatcher problem you mentioned at the start of this bug and the weird problem with clicking on edit button for key followed by save on the left.

Try pulling and let me know what happens. Not quite redmine 2.0, but will get there.

kubitron commented 12 years ago

Oh, @gituser, also fixed the gitolite_public_key error message issue you mentioned. (on testing branch).

ghost commented 12 years ago

Hello kubitron!!

thanks for your job on redmine_git_hosting :) do you have any news about the compatibility with redmine 1.4? let me know if you need help for testing ;)

thx

kubitron commented 12 years ago

News is that it is almost there. Turns out that a number of changes happened in the 1.3=>1.4 transition that impacted the plugin. Hopefully will have something to test within the next week.

plsamuel commented 12 years ago

It looks like other forks have started work on 2.0, I don't know if it would be mergeable though...

https://github.com/Liberty-Concepts/redmine_git_hosting/commit/da279fcac658038db51c864c216079620164c567

and the 2.0-migration branch of ericpaulbishop

kubitron commented 12 years ago

Hello. I have been getting the plugin compatible with Redmine 1.4, which is a big step. Afterwards, I'll start looking at 2.0. I anyone is willing to try the 1.4 port, that would be good... (Still in an Alpha/Beta stage).

kubitron commented 12 years ago

What would be useful is for people to try out the Redmine 1.4 support, which is on my testing branch.

gituser commented 12 years ago

hi. sorry for silence, i'm gonna test this version today and report back.

many thanks

kubitron commented 12 years ago

No worries. Probably good that you waited a day or so -- found a couple of bugs.

Let me know how it is working (and, of course -- register bugs individually so that I can track them).

jimblanc commented 12 years ago

Hey kubitron, I just wanted to thank you for your work on this. I've been trying to find a good git+redmine solution and this looks like the best bet. I'll try to contribute where I can (first by testing the 1.4 branch).

kubitron commented 12 years ago

@jimmyblanchard : Thanks. Really appreciate it.

lauer commented 12 years ago

I don't have the time to look at i today, but maybe others could test if this branch actually works with redmine 2.0? https://github.com/zucchi/redmine_git_hosting/commits/2.0-migration

If so, @kubitron could merge into this repository and save some time :)

UPDATE: I just created a checkout of his repository into mine environment. And after running the setup again, it seems to work. I can now see changesets inside redmine again.

Redmine version 2.1.2.stable.10544 Ruby version 1.9.3 (x86_64-linux) Rails version 3.2.8

kubitron commented 12 years ago

The current version 0.5.0x (for Redmine 1.4) is within epsilon of working with Redmine 2.0. I hope to have a 2.0-compatible version soon. I take it that you are a potential tester?

lauer commented 12 years ago

Sure. As I wrote, zucchi's 2.0 branch does actually work kinda okay. I there is some errors.

kubitron commented 12 years ago

Ok. Great! Stay tuned. (I take it that using Redmine 1.4 is out of the picture in the short term?)

lauer commented 12 years ago

Yes, I Can only test with Redmine 2.1 stable.

Den 04/10/2012 kl. 17.18 skrev John Kubiatowicz notifications@github.com:

Ok. Great! Stay tuned. (I take it that using Redmine 1.4 is out of the picture in the short term?)

— Reply to this email directly or view it on GitHub.

gituser commented 12 years ago

Ok. Great! Stay tuned. (I take it that using Redmine 1.4 is out of the picture in the short term?)

no-no. there are still a lot of plugins incompatible with 2.0, so 1.4 is pretty stable and good.

jimblanc commented 12 years ago

Hey, I've been testing the "testing" branch with Redmine 1.4.x over the past few days and haven't encountered any problems yet. The lab that I work at is about to start using it on their Redmine install so it'll be more thoroughly tested in coming days.

kubitron commented 12 years ago

@jimmyblanchard : Ok. Great! Let me know.

This is now the master branch, incidentally (although I left the pointer in "testing" for a bit). You might try switching your branch over to "master", since "testing" may go away soon. If you find problems, please report them as new issues (since I like to track problems).

lostar commented 12 years ago

Is there any alpha(or pre alpha) version for 2.0? I'm going migrate our environment to 2.0 soon, so I can test and may be debug/develop but my ruby/rails knowledge is limited =).

kubitron commented 12 years ago

@lostar, not yet, but will be next on my list. I pretty much know what needs to be done. Just need to find time (and I have to get an environment, which is a bit of work, since Ruby 1.9/Rails 3.0 is not supported on Redhat Linux yet (my primary environment). Will probably start with Redmine 2.0, then update to 2.1 (second update requires switching from Prototype.js to jQuery.js, which requires work).

lostar commented 12 years ago

Thanks for information! Could you please roughly point me what code should be reworked? Maybe I can help you with something.

TamiasSibiricus commented 11 years ago

@kubitron What status of this issue? If yor need for develop environment for redmine 2.1 or 2.2 with gitolite 3 maybe i can help with it. I think there no sense adopt this plugin for redmine 2.0.

lostar commented 11 years ago

I've patch (without Rails 2.x support) that fix some basic issues, but some (critical) Rails routes didn't work yet. ModalBox also doesn't work. Moreover I didn't test some fixes because do not have appropriate environment (mirroring and so on). Redmine with this plugin (+patch) successfully start but as I mentioned work not finished yet...

lauer commented 11 years ago

I have switched away from this plugin, and are using native git support, and the Redmine Bitbucket plugin for external hosted git on BitBucket (switch also support internal private projects for free)

TamiasSibiricus commented 11 years ago

@lostar Thanks for your job! But where i can get code for tests? I don't see forks of this plugin in your profile or any redmine 2 compatible branch in this repo.

qroac commented 11 years ago

@lostar and others: I'd provide a development environment with actual Redmine and Gitolite versions if needed. Please send me a message if you are interested.

lostar commented 11 years ago

I've drop patch to gist: https://gist.github.com/26900afd89f2ee4f7b52 Right now I do not have time to finish it but hope soon I'll manage it. ;)

TamiasSibiricus commented 11 years ago

@lostar Please tell me on wich branch and on which commit i must apply this gist? Thanks

lostar commented 11 years ago

redmine 2.1.2 redmine_git_hosting: 64a881861936b3c27cdca32db465132b58082d55

TamiasSibiricus commented 11 years ago

@lostar Thanks for your reply. But when i try to apply gist diff for this commit i got: tamias@Taurus:~/redmine_git_hosting$ git branch redmine2.2 64a881861936b3c27cdca32db465132b58082d55 tamias@Taurus:~/redmine_git_hosting$ git checkout redmine2.2 Switched to branch 'redmine2.2' tamias@Taurus:~/redmine_git_hosting$ git apply ../gistfile1.diff ../gistfile1.diff:444: trailing whitespace.

../gistfile1.diff:519: trailing whitespace. <%= labelled_remote_form_for @gitolite_public_key, ../gistfile1.diff:541: trailing whitespace. $('input[type="submit"]').each(function() { ../gistfile1.diff:625: trailing whitespace. <%= labelled_form_for :user, @user, ../gistfile1.diff:778: trailing whitespace. match ':repo_path/*path', error: patch failed: app/controllers/deployment_credentials_controller.rb:79 error: app/controllers/deployment_credentials_controller.rb: patch does not apply

Maybe you point me to other commit. I just want start new branch from that point, apply your patch and after merging from master i want to try it on redmine 2.2