search

kubitron / redmine_git_hosting

A ChiliProject/Redmine plugin which makes configuring your own git hosting easy.
78 stars 15 forks source link

Errors while uninstalling plugin #68

Closed saric closed 12 years ago

saric commented 12 years ago

My Redmine config:

Testing was done on clean Redmine installation (fresh install without any other plugins) and using redmine_git_hosting from testing branch.

Plugin uninstallation procedure gives an error:

$ rake db:migrate:plugin NAME=redmine_git_hosting VERSION=0 RAILS_ENV=production Mysql::Error: Can't DROP 'notified_cia'; check that column/key exists: ALTER TABLEchangesetsDROPnotified_cia``

kubitron commented 12 years ago

Hmmm... Didn't know if that code has ever been tested (that would be a migration before I took over the plugin). Did you successfully run the "db:migrate_plugins" first?

saric commented 12 years ago

Yes, I did.

kubitron commented 12 years ago

Ok. Is this a high-priority issue right now? I may need to save my hacking cycles to getting the 1.4 release in good shape. I will look at it, however.... (Is that the right syntax to remove all migrations for a plugin? I guess I always wondered how to undo a migrate_plugins).

saric commented 12 years ago

No, this is not high-priority issue right now. We all want to install plugin and use it, and not to uninstall it :-) Yes, that's correct command to downgrade redmine database, according to Redmine documentation: http://www.redmine.org/projects/redmine/wiki/Plugins

Keep up the good work!

kubitron commented 12 years ago

Say @saric have you been able to use the testing branch with Redmine1.4 successfully? I'm hoping to push it out to the master branch soon...

saric commented 12 years ago

I won't be able to test it until next week.

kubitron commented 12 years ago

Ah. I thought you were using it already, since you were reporting bugs.... (I haven't debugged the inability to uninstall yet).

kubitron commented 12 years ago

Hello again.

So, I believe that this problem with uninstallation should be fixed. Can you try the head of master?

kubitron commented 12 years ago

Just checking in -- I'd like to close out this bug... I believe that uninstallation is now working.

saric commented 12 years ago

Hello John. Sorry, I wasn't able to test it earlier. Uninstallation works now as expected. Thank you for your work.

kubitron commented 12 years ago

Great! Let me know if the plugin is still working for you (head of master now includes some patches to make < Redmine 1.4 work again (my bad) -- hopefully didn't mess up Redmine 1.4 support).

Thanks for closing out this bug.

saric commented 12 years ago

Yes, it works with code from master branch.

kubitron commented 12 years ago

Good. I am hoping to actually freeze the 0.5.0x release. Thanks again for the debugging. I don't normally like to release code in a beta (alpha?) state, but the bugs got shaken out a lot faster than they would have otherwise.