search

kubo / plthook

Hook function calls by replacing PLT(Procedure Linkage Table) entries.
762 stars 156 forks source link

Allow to build plthook without error reporting (elf) #22

Closed milabs closed 4 years ago

kubo commented 5 years ago

I don't feel the benefits of the change. When plthook_error() isn't called, there are no difference except penalty of writing error messages to the internal buffer. However I don't care such small penalty in plthook because plthook functions are not called frequently.

If you have another point of view, could you tell me?

milabs commented 4 years ago

If you have another point of view, could you tell me?

Actually, the only concern I have about that is the footprint of the library which makes sense in some applications. In my opinion, it would be better to have a compile-time option to be able to get rid of error strings.

kubo commented 4 years ago

Actually, the only concern I have about that is the footprint of the library which makes sense in some applications.

That's right if the reduced memory footprint is about several hundred mega bytes. That may be if several mega bytes. However the patch reduces 512 bytes or so. I doubt who care about it nowadays.