kubo / plthook

Hook function calls by replacing PLT(Procedure Linkage Table) entries.
745 stars 152 forks source link

A minor typo issue. #33

Open ZhangZhuoSJTU opened 3 years ago

ZhangZhuoSJTU commented 3 years ago

Hi,

Thanks for your great efforts in developing plthook. It is a very useful tool.

While I am going through the code, I found a minor typo in code which in most cases does not affect the correctness but may be wrong sometimes.

I feel both below statements should use dyn->d_un.d_val instead of dyn->d_un.d_ptr.

https://github.com/kubo/plthook/blob/8bf14993344ff4377500e95e4fb412440639255b/plthook_elf.c#L631

https://github.com/kubo/plthook/blob/8bf14993344ff4377500e95e4fb412440639255b/plthook_elf.c#L638

It is quite trivial, so I hope I would not bother you too much.

Thanks.