search

kubo / ruby-oci8

Ruby-oci8 - Oracle interface for ruby
Other
169 stars 75 forks source link

Tests for binding integer cursor in parameters #148

Closed javornikolov closed 7 years ago

javornikolov commented 7 years ago

Add tests for binding a range of small and large integer variables directly (not through OraNumber).

I have only ran the tests with Ruby 2.4.0, 2.3.3 and Oracle 11.2 (tests passed). If the added tests are correct for any versions supported - perhaps it makes sense to also remove the comment at cursor.rb#L61-L62 as it leads to implementations with separate branches for Fixnum and Bignum.

javornikolov commented 7 years ago

@kubo, I'm ready with rename of the test class and the other planned refinements here.

kubo commented 7 years ago

Thank you!