kubo / ruby-oci8

Ruby-oci8 - Oracle interface for ruby
Other
169 stars 75 forks source link

Suppress expected exceptions tested with Ruby 2.5 #181

Closed yahonda closed 6 years ago

yahonda commented 6 years ago
$ make check
... snip ...

Traceback (most recent call last):
        3: from /home/yahonda/git/ruby-oci8/test/test_break.rb:42:in `block in do_test_ocibreak'
        2: from /home/yahonda/git/ruby-oci8/test/test_break.rb:46:in `rescue in block in do_test_ocibreak'
        1: from /home/yahonda/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/minitest-5.10.3/lib/minitest/assertions.rb:174:in `assert_equal'
/home/yahonda/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/minitest-5.10.3/lib/minitest/assertions.rb:139:in `assert': OCIBREAK. (Minitest::Assertion)
... snip ...

Refer https://www.ruby-lang.org/en/news/2016/11/09/ruby-2-4-0-preview3-released/

This pull request suppresses expected exceptions by setting report_on_exception = false it also supports Ruby 2.3 which does not havereport_on_exception.

kubo commented 6 years ago

Thank you! I'll release ruby-oci8 2.2.5.1 tomorrow to make binary gems which support ruby 2.5.0 on Windows x64 and x86.

yahonda commented 6 years ago

Good news. Thank you.