kubo / ruby-oci8

Ruby-oci8 - Oracle interface for ruby
Other
169 stars 75 forks source link

Fix for #114 is not working with Rails 5.2 which bundles bootsnap by default #192

Closed yahonda closed 6 years ago

yahonda commented 6 years ago

Steps to reproduce

This is originally reported at https://github.com/rails/rails/issues/32811 . It looks like Fix for #114 is not working with Rails 5.2 which bundles bootsnap by default.

$ rails new myapp -d oracle
$ cd myapp/
$ echo "gem 'ruby-oci8'" >> Gemfile
$ bundle install
$ bundle exec rake -T
Don't require 'ruby-oci8'. Use "require 'oci8'" instead. 'ruby-oci8.rb' was added only for 'Bundler.require'.
rake about                              # List versions of all Rails frameworks and t...
... snip ...
rake yarn:install                       # Install all JavaScript dependencies as spec...
$

I expect Don't require 'ruby-oci8'. Use "require 'oci8'" instead. 'ruby-oci8.rb' was added only for 'Bundler.require'. should not appear here.

Versions:

$ rails -v
Rails 5.2.0
$ ruby -v
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]
yahonda commented 6 years ago

cc @y-yagi @francescm

kubo commented 6 years ago

Thanks for reporting this issue. I removed the warning.

francescm commented 6 years ago

Thank you so much.

yahonda commented 6 years ago

Thanks for the fix.