search

kubo / ruby-oci8

Ruby-oci8 - Oracle interface for ruby
Other
169 stars 75 forks source link

(Nix) Allow for specifying include/library paths #210

Closed dminuoso closed 5 years ago

dminuoso commented 5 years ago

Currently this package is not buildable on Nix for a few reasons.

It uses a hardcoded /sbin/ldconfig reference, requires LD_LIBRARY_PATH hacks to introduce oracle-instantclient to the extconf.rb process, and the package further assumes some special directory structure (which the oracle-instantclient package from nixpkgs does not follow)..

Rather than try identifying nix and special casing the lib/include paths, it is easier if nix can control the lib/include paths itself.

This patch adds support for three flags. --with-instant-client-dir, --with-instant-client-include and --with-instant-client-lib. The behavior of the package is left unchanged if those flags are not specified.

kubo commented 5 years ago

@dminuoso Thanks for making the pull request. Could you fix this error on travis-ci? Your patch removed OraConfFC.new(). So it cannot be compiled for ORACLE_HOME-based client.

dminuoso commented 5 years ago

@kubo I did not realize that I deleted one line too many. It's fixed

kubo commented 5 years ago

@dminuoso Thanks. It was merged!