search

kubo / ruby-oci8

Ruby-oci8 - Oracle interface for ruby
Other
169 stars 75 forks source link

Make OCIError a type of Error #264

Closed matthewtusker closed 1 month ago

matthewtusker commented 1 month ago

I'm in the process of creating an OpenTelemetry Gem for ruby-oci8. One of the things that's adding a lot of complication is the fact that OCIError isn't any type of Error, it's just a basic Class.

This PR changes OCIError to inherit from StandardError. This should make it easier for tools to catch and do something with them when they're raised.

matthewtusker commented 1 month ago

I have misunderstood what's required here. I need to look at OCIException and make that a type of Error. It looks like I'm going to learn some C!