Add query methods for Statement which take ownership

kubo / rust-oracle

Oracle driver for Rust

189 stars 44 forks source link

Add query methods for Statement which take ownership #50

Closed christoph-heiss closed 2 years ago

christoph-heiss commented 2 years ago

Hi,

basically as the title and commit message says. It mimics the interface of Connection::query_*(), which take ownership of the statement instead of borrowing it. I hope the method names are okay, but I'll happily rename them if there are any better suggestions.

This can be used if StatementBuilder needs to be used, without having to store both Statement and the ResultSet in a struct together (which is quite painful in Rust to do).

Thanks!

kubo commented 2 years ago

I apologize that I have not replied so long. I have thought about it one or two hours per week.

Could you change as follows?

rename into_query_as to into_result_set
rename into_query_as_named to into_result_set_named
remove into_query and into_query_named (There are many query methods so I don't want to add new ones as possible.)

christoph-heiss commented 2 years ago

I just pushed a new version with your suggestions incorporated.

Thanks for looking into it!