kubo / rust-oracle

Oracle driver for Rust
178 stars 43 forks source link

Fix RowValue which can reference an invalid Ok that defined outside #62

Closed importcjj closed 1 year ago

kubo commented 1 year ago

Thanks!

Could you change tests/procmacro.rs as follows?

  1. Rename fn test_procmacro_ok_shadow() to fn procmacro_ok_shadow()
  2. Add #[allow(dead_code)] to fn procmacro_ok_shadow() to suppress warning: function is never used
  3. Add #[allow(unused_imports)] to use AnotherResult::Ok; to suppress warning: unused import
  4. Run cargo fmt
kubo commented 1 year ago

@importcjj After you removes the empty line between #[allow(dead_code)] and enum AnotherResult<T, E>, could you merge your commits into one by git rebase -i (see here) and git push -f in order to simplify revision history?

This is optional. If you don't, I'll use "squash and merge" instead of "merge commit" (default option). (see here)

importcjj commented 1 year ago

I removed the empty line, actual it doesn't take any effect.

kubo commented 1 year ago

Thanks for contribution.

I'll release 0.5.6 this weekend or the next weekend.