search

kucaahbe / rspec-html-matchers

Old school have_tag, with_tag(and more) matchers for rspec 3 (Nokogiri powered)
http://rubygems.org/gems/rspec-html-matchers
MIT License
199 stars 90 forks source link

Fix frozen string literals #44

Closed jeroenvisser101 closed 8 years ago

jeroenvisser101 commented 8 years ago

This PR adds support for the Ruby 2.3.0 magic comment # frozen_string_literal: true, which is proposed as default in Ruby 3.

This means string concatenation with << is not allowed anymore.

jeroenvisser101 commented 8 years ago

@kucaahbe I understand this might not be something you'd want to merge yet, but I'm proposing it anyways. If you'd like to have this, let me know, I'll update the changelog as well 👍

kucaahbe commented 8 years ago

@jeroenvisser101 thanks for adding this, as long as it works now and potentially fixes string issues with 3.x ruby I don't see any reason to not merge. Could you please update changelog with this info? For anyone wondering what is frozen string literals I leave this link here: http://blog.lucascaton.com.br/2016/01/19/what-is-frozen_string_literal-in-ruby/

jeroenvisser101 commented 8 years ago

👍! Will update it now! :)

jeroenvisser101 commented 8 years ago

@kucaahbe – updated and rebased

jeroenvisser101 commented 8 years ago

@kucaahbe the build failure seems to be due to bundler, and not related to this PR, tests pass locally

kucaahbe commented 8 years ago

@jeroenvisser101 thanks for update! The build is failing because of mime-types-data gem does not allow itself to install on 1.9.3 ruby (not sure what to do with this right now, seems not pretty urgent)

jeroenvisser101 commented 8 years ago

@kucaahbe alright haha, seems fine to me as well – will you be releasing a new version soon?

kucaahbe commented 8 years ago

@jeroenvisser101 yes, as soon as tests pass

jeroenvisser101 commented 8 years ago

Great, thanks! 👍