with_tag in a block is not restricted to the found element

kucaahbe / rspec-html-matchers

Old school have_tag, with_tag(and more) matchers for rspec 3 (Nokogiri powered)

http://rubygems.org/gems/rspec-html-matchers

MIT License

199 stars 90 forks source link

Closed randoum closed 7 years ago

randoum commented 7 years ago

is_expected.to have_tag('div#menu') {
  with_tag 'a.hidden', count: 1
}

Do find all a.hidden in the entire document.

With 0.8.2 only, does not append with 0.8.1 I suspect #55 to be responsible

randoum commented 7 years ago

ping @kucaahbe @misaka

jcouball commented 7 years ago

I believe this is a duplicate of issue #41

jcouball commented 7 years ago

:+1: I see this issue too. I have had to pin to the 0.8.1 version of the gem as a workaround.

randoum commented 7 years ago

@jcouball would you mind to check #59 and see if your issues are fixed ?

jcouball commented 7 years ago

@randoum the changes in #59 seem to fix the problems with my tests. Thank you!

randoum commented 7 years ago

Fixed by #59