search

kucaahbe / rspec-html-matchers

Old school have_tag, with_tag(and more) matchers for rspec 3 (Nokogiri powered)
http://rubygems.org/gems/rspec-html-matchers
MIT License
199 stars 90 forks source link

Added with_button and without_button matchers #7

Closed cimm closed 13 years ago

cimm commented 13 years ago

Hi Dmitry,

We are using your RSpec view matchers in one of our projects and needed to check the presence of a button in a form. You don't have a matcher for a button yet so I added one.

The other commit is just some whitespace stuff. Some files have both tabs and spaces, I can't stand that, it makes the code difficult to read. ;)

Could you please have a look at the code and merge it in if you think it's good enough?

Thanks for building this little gem, I use it on all my projects right now.

-- Simon

kucaahbe commented 13 years ago

"I can't stand that" - me too, that stuff was written in unconfigured vim(my experiments) shame on me - I didn't know about separated ''button tag", thanks for request and using gem.

kucaahbe commented 13 years ago

I need to finish adding html5 input matchers and version 0.2.0 will be released.

cimm commented 13 years ago

Whow, that's fast, thanks man! I extracted the inline HTML blocks from the tests as well, will create another pull request.

kucaahbe commented 13 years ago

I'm waiting:)