search

kucaahbe / rspec-html-matchers

Old school have_tag, with_tag(and more) matchers for rspec 3 (Nokogiri powered)
http://rubygems.org/gems/rspec-html-matchers
MIT License
199 stars 90 forks source link

Supports RSpec 4 #72

Closed wbotelhos closed 4 years ago

wbotelhos commented 4 years ago

To avoid an error on Rails 6 https://github.com/rspec/rspec-rails/issues/2177, we need RSpec 4.

kucaahbe commented 4 years ago

not sure I understand what exactly the issue here, could you provide more details? From what I read from the links in PR looks like it's specifically rspec-rails, which has nothing to do here, also worth to mention that rspec version 4 does not exist yet

wbotelhos commented 4 years ago

I'm sorry about my bad text.

  1. Using Rails 6, we had an error on rspec-rails;
  2. To fix it, we need to use rspec-rails on branch 4-0-dev;
  3. Using 4-0-dev bundle says that only supports rspec-html-matchers < 4.

But I could solve it using version 4.0.0.beta3, since bundle does not whiny about the version. Maybe the name .beta* works and 4-0-dev.

Finally, who use Rails 6 will need rspec-rails 4 and so an updated version of rspec-html-matcher. But for now, we cool with beta.

kucaahbe commented 4 years ago

rspec-rails and this library has no relation, this library has relation only with rspec, and even rspec-rails 4 does not have relation with (this is proposed in change) rspec 4. To be exact, could you illustrate this statement: "Using 4-0-dev bundle says that only supports rspec-html-matchers < 4."? Please provide exact error message along with info about tool which produced it (name, version, command-line arguments if applicable etc.).

wbotelhos commented 4 years ago

When i say rspec-rails, i'm saying rspec, since it walks together. I just want to make sure that rspec 4 could be used, but don't mind, 4.0.0.beta3 worked.

kucaahbe commented 4 years ago

got it, please no worries, once rspec 4 will be a thing it will be supported, for now it's a bit early to declare it in gemspec.