Tables.unmodifiableTable and unmodifiableRowSortedTable

kucci / guava-libraries

Automatically exported from code.google.com/p/guava-libraries

Apache License 2.0

0 stars 0 forks source link

Tables.unmodifiableTable and unmodifiableRowSortedTable #410

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Hi,

I'm very pleased and thankful to finally see the Table coming in Guava. However 
I'm wondering if it is purposely that no ImmutableTable implementation is 
provided. If it was simply forgotten, is it possible to add/implement it?

Thank you!

Original issue reported on code.google.com by ogregoire on 1 Sep 2010 at 1:42

GoogleCodeExporter commented 9 years ago

we have an ImmutableTable that we don't think is quite ready for release yet.

Original comment by kevinb@google.com on 1 Sep 2010 at 9:58

GoogleCodeExporter commented 9 years ago

Original comment by fry@google.com on 28 Jan 2011 at 5:06

Changed state: Accepted
Added labels: Type-Enhancement

GoogleCodeExporter commented 9 years ago

Issue 622 has been merged into this issue.

Original comment by cgdec...@gmail.com on 16 May 2011 at 12:17

GoogleCodeExporter commented 9 years ago

Yep, I could really use this right now to create constants.

Original comment by j...@nwsnet.de on 11 Jul 2011 at 4:38

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 13 Jul 2011 at 6:18

Changed state: Triaged

GoogleCodeExporter commented 9 years ago

As Kevin said, we have this internally, and eventually it will make its way out.

Original comment by cpov...@google.com on 13 Jul 2011 at 8:34

Changed title: ImmutableTable
Changed state: Started

GoogleCodeExporter commented 9 years ago

Are there plans for a Tables#unmodifiableTable view in addition to this 
immutable implementation?

Original comment by joe.j.kearney on 21 Jul 2011 at 3:21

GoogleCodeExporter commented 9 years ago

I suppose that would probably make sense.

Original comment by kevinb@google.com on 23 Jul 2011 at 6:41

GoogleCodeExporter commented 9 years ago

Should I do this?

Original comment by wasserman.louis on 13 Oct 2011 at 10:28

GoogleCodeExporter commented 9 years ago

Issue 756 has been merged into this issue.

Original comment by kurt.kluever on 13 Oct 2011 at 10:49

GoogleCodeExporter commented 9 years ago

Please do.

Original comment by kevinb@google.com on 16 Oct 2011 at 3:33

Changed title: Tables.unmodifiableTable and unmodifiableRowSortedTable
Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Kevin, the new summary doesn't include include ImmutableTable anymore. This is 
however the base of the issue reported here. Was it something you forgot or was 
it intentional? If it was intentional, may I ask why? Thanks!

Original comment by ogregoire on 16 Oct 2011 at 9:54

GoogleCodeExporter commented 9 years ago

ImmutableTable's already done; that's why.  ;)  See 
http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/collect
/ImmutableTable.html

My change introducing unmodifiableTable and unmodifiableRowSortedTable is 
available for review at http://codereview.appspot.com/5266049/ and has been 
mailed to Chris.

Original comment by wasserman.louis on 16 Oct 2011 at 10:40

Changed state: Started

GoogleCodeExporter commented 9 years ago

Patch committed as of 
http://code.google.com/p/guava-libraries/source/detail?spec=svnf67e430a61873ed1e
58d00a23b5834057787cc11&r=99091e882f9c6985315f9498b2125af9141af431 .

Original comment by wasserman.louis on 15 Nov 2011 at 4:56

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

This issue has been migrated to GitHub.

It can be found at https://github.com/google/guava/issues/<id>

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:15

Added labels: MigratedToGitHub

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 3 Nov 2014 at 9:09

Added labels: Restrict-AddIssueComment-Commit