kuceb / cypress-plugin-retries

A Cypress plugin to retry failed tests.
MIT License
237 stars 20 forks source link

Don't repeat on cypress open #51

Open fr0 opened 4 years ago

fr0 commented 4 years ago

I think this plugin should only take effect on cypress run, not on cypress open. When using cypress open, having the plugin makes it harder to debug problems because it starts repeating the test after an error and scrolls past the error.

kuceb commented 4 years ago

@fr0 agreed. I'll turn that off by default and add a configuration variable to turn it back on

dialex commented 4 years ago

Any update on this? I just finished installing and configuring it and the tests simply don't run on cypress open. If I do cypress run then tests run and I can see retries as expected.

There are no errors on console or browser. I'm using the latest Chrome with Cypress 3.7.0

kuceb commented 4 years ago

@dialex if you remove the retries plugin does cypress work as normal?

dialex commented 4 years ago

Oh no, you're right, even without this plugin the tests don't run on cypress open 😵😱

Offtopic: I'm using Cypress 3.7.0 and I did not change anything about it. But Chrome recently updated to v80. Could it be a conflict between versions? Because the tests do run if I choose Electron v73.

Update: I upgraded Cypress to 4.0.1 and the issue persists... You can mark all my comments as offtopic, this is not related with this plugin. I guess I'll open an issue on Cypress.

kuceb commented 4 years ago

@dialex I believe its a problem with Chrome 80.