search

kucharzyk / spring-angular2-starter

PROJECT DISCONTINUED
MIT License
210 stars 65 forks source link

Docker build and run support added #13

Closed tsukhu closed 8 years ago

tsukhu commented 8 years ago

The angular2 spring boot integration is good , but very cumbersome without docker support. Changes have been added to enable Docker support via docker compose and maven plugin docker .

kucharzyk commented 8 years ago

It looks great. Thanks.

I'll review it later (after work) and merge.

btw: next time please create pull request to dev branch

kucharzyk commented 8 years ago

I'm sorry but I can't merge this PR.

Docker is great but removing "eureka.instance.hostname" property will break existing functionallity and it won't work without docker.

I'll move your changes to dev branch and try to make it works with and without docker.

kucharzyk commented 8 years ago

I've just recreated your configuration on dev branch.

I'll try to create dedicated profiles for docker and standalone configurations

tsukhu commented 8 years ago

I tried out the dev branch build and run (using Docker) .. it works perfectly :+1: One addition that can be done is to have spring-boot admin added as well

tsukhu commented 8 years ago

One more suggestion .. we could potentially have only one copy of wait-for-service.sh (since they are identical) and copy it from a common parent location to all docker builds