Lombok - Githubissues

kucharzyk / spring-angular2-starter

PROJECT DISCONTINUED

MIT License

210 stars 65 forks source link

Lombok #46

Closed tomaszkolodziej closed 7 years ago

tomaszkolodziej commented 7 years ago

Add lombok support.

Why lombok was removed in version 1.9.0? Is there was any reason to remove lombok from project?

kucharzyk commented 7 years ago

Lombok is great tool and I use it everyday in my work but:

It may not survive changes in java 9
You need lombok plugin for your IDE (some users may be disoriented)
It may be source of problems if You don't know how it works like @EqualsAndHashcode which don't call superclass by default.
Everyone can add lombok on his own. Delombok is harder.

Do you think it's worth adding Lombok?

tomaszkolodziej commented 7 years ago

I don't know nothing about java 9 :)
agree, some users may be disoriented to install lombok plugin in intellij or other ide,

Ok, may be better option to wait. I will wait for java 9 and open this question/task or (may be better solution) add lombok plugin on my own (after java 9 released).

kucharzyk commented 7 years ago

I've checked current status of Lombok:

There was no single commit for about 3 moths.
There are still some issues with upcomming jdk9

tsukhu commented 7 years ago

I agree .. Ideally lets keep the starter project related to the Spring and Angular 2 eco-system only. Add-ons like lombok should be left to the developers discretion

kucharzyk commented 7 years ago

In the future We can consider Immutables or AutoValue as better (but less powerfull) alternatives.

https://dzone.com/articles/lombok-autovalue-and-immutables

For now I'm closing this issue