kuchejak / obsidian-bible-linker-plugin

Obsidian.md plugin that allows you to link multiple bible verses easily
MIT License
81 stars 5 forks source link

Link to multiple translation at once #29

Open ickc opened 1 year ago

ickc commented 1 year ago

Thanks for #13. Would you consider allowing multiple translation all at once? I.e. allowing selection of more than 1 translations, and then when copied, it will be

translation 1 verse 1
translation 2 verse 1
translation 1 verse 2
...
kuchejak commented 1 year ago

Hello, I have looked into the code, and this seemingly small change would lead to quite a lot of work because it requires working with multiple files at once instead of just with one. Also, I'm not quite sure about the suggested output because I don't think many people would want to have the translations change with every verse; for me personally, it would be much more natural to have one translation (all verses) and then the second translation (also all verses).

So for now, I'm not going to implement this suggestion, sorry. If more people request it, I may reconsider. But If you are willing to code it yourself, feel free to create a PR.

ickc commented 1 year ago

I understand the decision to not implement this feature because of the design of the existing code. But I think at least allow the user to choose more than 1 translations and it would just copy it as you suggested, the whole section for the 1st translation, and then the other?

P.S. About the argument that "I don't think many people would want to have the translations change with every verse", just know that bilingual speakers do this all the time. For example:

Screenshot 2023-10-30 at 9 47 37 PM

To me, this is the only sensible way to have multiple translations to appears in text at once. The "context window" of multiple verses is too large to make having multiple translations at once to be useful.

kuchejak commented 1 year ago

Ok, I'll keep the issue open and hopefully get to it someday, I would like to improve the plugin architecture one day anyway, but sadly I don't have enough time to work on it right now.

Also thank you for the bilingual example, I haven't thought of that.