fix sibling iters - Githubissues

kuchiki-rs / kuchiki

(朽木) HTML/XML tree manipulation library for Rust

MIT License

470 stars 54 forks source link

Closed erikbrinkman closed 1 year ago

erikbrinkman commented 1 year ago

This pr fixes incorrect output of sibling iteration methods when there's no parent.

To achieve this I pulled out the code for first/last sibling and then simplified the appropriate methods.
I also added a simple test to verify this works.
I also ran cargo fmt and cargo clippy addressing each of the issues. Those two steps are in previous commits which hopefully can be viewed separated. I tried to make a stacked PR but it looks like that only works in the same repository.

SimonSapin commented 1 year ago

I will soon archive this repository and make it read-only, so this PR will not be addressed: https://github.com/kuchiki-rs/kuchiki#archived