search

kuchiki-rs / kuchiki

(朽木) HTML/XML tree manipulation library for Rust
MIT License
470 stars 54 forks source link

Update cssparser #53

Closed RazrFalcon closed 5 years ago

SimonSapin commented 5 years ago

Isn’t cssparser a private dependency in Kuchiki? Either way, I’d take a PR.

RazrFalcon commented 5 years ago

There are some breaking changes and I'm not sure how to resolve them.

kpcyrd commented 5 years ago

html5ever is also outdated now. I'm about to upload kuchiki to debian as soon as all dependency are accepted, even if this is a private dependency we would either need upload an old version of cssparser (and the dependency of that specific version which are outdated as well), or write a patch that uses the latest versions, which unfortunately seems non-trivial according to @RazrFalcon's comment.

An update would be very appreciated!

SimonSapin commented 5 years ago

https://crates.io/crates/kuchiki/0.7.3 depends on cssparser 0.25 and html5ever 0.23. (And does not contain code changes, so I’m not sure what those breaking changes were.)

kpcyrd commented 5 years ago

Awesome, thank you!