search

kuchiki-rs / kuchiki

(朽木) HTML/XML tree manipulation library for Rust
MIT License
470 stars 54 forks source link

Switch to 2018 edition #63

Closed mashedcode closed 4 years ago

mashedcode commented 4 years ago

Basically upgrade dependencies and cargo fix.

Poorly cssparser can't be upgraded yet as we're waiting for a selectors crate release.

SimonSapin commented 4 years ago

Are you aware that you don’t need every crate in your program to be on the same edition? And that future compiler versions will always support older editions? You can start using Rust 2018 in your own code without you whole dependency graph doing so. That’s the whole point of having this "edition" mechanism, rather than an incompatible Rust 2.x version.

mashedcode commented 4 years ago

@SimonSapin the reason why I included the upgrade to the 2018 edition in this PR is because otherwise it wouldn't compile due to dependent crates that use 2018 edition features.

To be clear I really just need the upgrade to html5ever 0.25 to avoid clashes with other crates that depend on the up-to-date version.

SimonSapin commented 4 years ago

To be clear I really just need the upgrade to html5ever 0.25 to avoid clashes with other crates that depend on the up-to-date version.

Ah, fair enough. That should have been the title of the PR, though!

mashedcode commented 4 years ago

@SimonSapin the switch to 2018 edition is the "major" change. Yes, I could've called it "Upgrade dependencies".

mashedcode commented 4 years ago

Any feedback? Please close the PR if it's not considered for merging.

jens1o commented 4 years ago

I'd also be keen whether this is something that wants to be resolved (i.e. switching to the current edition), or not.

Ygg01 commented 4 years ago

@mashedcode @jens1o does jdm PR #65 already has what you peeps need?

mashedcode commented 4 years ago

Closing in favor of #65 which will hopefully be merged after review.