search

kucrut / vite-for-wp

Vite integration for WordPress plugins and themes development.
GNU General Public License v2.0
260 stars 29 forks source link

[BUG] Manifest is created in wrong directory after build #80

Closed j7-dev closed 5 months ago

j7-dev commented 9 months ago

Hello,

I am grateful for your contributions. 🙏

I found a bug after I run `yarn build‵

Problem in "kucrut/vite-for-wp": "^0.8.0"

manifest.json will be created in dist/.vite directory which is WRONG

image

function get_manifest will try to find the manifest file in __DIR__ . '/js/dist', NOT in __DIR__ . '/js/dist/.vite'

That will cause an error, lead to empty assets, so the built js won't be enqueue.

No problem in "kucrut/vite-for-wp": "^0.5.2"

image

Update

It seems the manifest.json will be created in dist/.vite in vite 5

reference https://github.com/nystudio107/craft-vite/issues/77 https://www.drupal.org/project/vite/issues/3401054

j7-dev commented 8 months ago

I resolve this with this commonJS temporary.

move dist/.vite/manifest.json to dist/manifest.json

https://github.com/j7-dev/wp-react-plugin/blob/master/release/mv-manifest.cjs

kucrut commented 5 months ago

This is fixed in #92.