search

kud / ed-209

I'm an IRC bot!
8 stars 4 forks source link

Add urban #52

Closed Bigorneau closed 9 years ago

Bigorneau commented 9 years ago

Add an Urban Dictionary listener. Using the JSON API it returns the first and best rated result with an example. Line breaks in results are substituted with spaces.

result sample: url: http://api.urbandictionary.com/v0/define?term=javascript%20programming

MoOx commented 9 years ago

A description is never enough. I had to read the code to understand it's an interface for the urban dictionary.

madx commented 9 years ago

@MoOx I don't understand your comment. There is a description in the PR and we never have a descriptive comment in other listeners

kud commented 9 years ago

Instead of participating to this deprecated project, we should put our effort on https://github.com/putaindebot/core

madx commented 9 years ago

Yes, but, well, err… This one works?

kud commented 9 years ago

Sadly yes.

MoOx commented 9 years ago

It works great with one channel. So the main issue right now is the multichannel. @bloodyowl (which make the entire core and current plugins) has not handled multi channel for the new bot core (based on stream). It's probably not an easy things to do. Not sure, and for my concern, I don't want to take some time for that right now.

Nyalab commented 9 years ago

I do not know if it does work great on one channel, sometimes it does not respond or reply at all. And i tried to work on the several channels feature, but the code designed by @bloodyowl is not designed to use native features of the irc module, so i do not get how he wants to get it done.

MoOx commented 9 years ago

We should discuss about that here https://github.com/putaindebot/core/issues/5